io-sim: exception handling in traceResult #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in traceResult to allow asynchronous exceptions from QuickCheck operators (within, discardAfter) to pass through without being caught. The fix ensures that IOSim simulations can be properly terminated by QuickCheck's timeout mechanisms.
Key changes:
- Modified
traceResultto filter asynchronous exceptions usingtryJustandfromException - Added
-fno-full-lazinessGHC option to the test module to prevent GHC from optimizing away lambda wrapping - Added two unit tests (
unit_discardAfterandunit_within) to verify the fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| io-sim/src/Control/Monad/IOSim.hs | Modified traceResult to let asynchronous exceptions pass through, added import for SomeAsyncException |
| io-sim/test/Test/Control/Monad/IOSim.hs | Added GHC compiler flag and two unit tests to verify QuickCheck timeout operators work correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coot
force-pushed
the
coot/io-sim-exception-handling
branch
3 times, most recently
from
f0fad1c to
fe2b46b
Compare
coot
changed the title
coot
force-pushed
the
coot/io-sim-exception-handling
branch
from
fe2b46b to
ce080af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230